Skip to content

Set schema:logo and schema:photo as subproperties of schema:image #114#115

Merged
danbri merged 1 commit intoschemaorg:masterfrom
Sachini:subproperty_image
Sep 10, 2014
Merged

Set schema:logo and schema:photo as subproperties of schema:image #114#115
danbri merged 1 commit intoschemaorg:masterfrom
Sachini:subproperty_image

Conversation

@Sachini
Copy link
Contributor

@Sachini Sachini commented Sep 5, 2014

Issue : #114

@danbri
Copy link
Contributor

danbri commented Sep 10, 2014

I had the same reaction as @scor to the "A sub property of image" sentences, having never liked them much in the actions vocab either. But you're right we do use the phrase elsewhere. However now that the site has built-in navigation structures for sub-properties, my preference would be to simplify the wording of the Action-related subproperties and to avoid adding that phrase here. Does this make sense?

ps. thanks for the pull req :)

danbri added a commit that referenced this pull request Sep 10, 2014
Set schema:logo and schema:photo as subproperties of schema:image #114
@danbri danbri merged commit fc3c70c into schemaorg:master Sep 10, 2014
@danbri
Copy link
Contributor

danbri commented Sep 10, 2014

(I'll back out the comment changes manually.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants