Skip to content

One possible error in buffer.py #6281

@lyy0095

Description

@lyy0095

class RewardSignalUtil:
@staticmethod
def rewards_key(name: str) -> AgentBufferKey:
return RewardSignalKeyPrefix.REWARDS, name

@staticmethod
def value_estimates_key(name: str) -> AgentBufferKey:
    **return RewardSignalKeyPrefix.RETURNS, name**

@staticmethod
def returns_key(name: str) -> AgentBufferKey:
    **return RewardSignalKeyPrefix.RETURNS, name**

@staticmethod
def advantage_key(name: str) -> AgentBufferKey:
    return RewardSignalKeyPrefix.ADVANTAGE, name

@staticmethod
def baseline_estimates_key(name: str) -> AgentBufferKey:
    return RewardSignalKeyPrefix.BASELINES, name

Why the return of def value_estimates_key(name: str) is the same as def returns_key(name: str) ?
Here may be an error in codes!

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssue describes a potential bug in ml-agents.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions