... and use the built-in ones instead.
Also replace assertDictEqual because assertEqual should select
an appropriate method automatically[1].
[1] https://docs.python.org/3.13/library/unittest.html
The list of type-specific methods automatically used by assertEqual()
are summarized in the following table. Note that it’s usually not
necessary to invoke these methods directly.
Change-Id: I4b7d3563e5a025cd3efa602a28c12865dcf3474d
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
Update all .py source files by
$ pyupgrade --py3-only $(git ls-files | grep ".py$")
to modernize the code according to Python 3 syntaxes.
pep8 errors are fixed by
$ autopep8 --select=E127,E128,E501 --max-line-length 79 -r \
--in-place taskflow
Also add the pyupgrade hook to pre-commit to avoid merging additional
Python 2 syntaxes.
Change-Id: Ifd0a0ade9789497482c7937bffd82c48acfb3d78
networkx 2.8.3 will raise errors if certain characters, such as a colon, in the node names and the string is not quoted.
This patch double quotes flow, node, and task string representations to make sure there are not issues with these characters occuring in the names.
Story: 2010083
Change-Id: Ib0941cddf14dde5d6b9f97fe0224d6e6f3975226
With the removal of Python 2.x we can remove the unittest2 compat
wrappers and switch to assertCountEqual instead of assertItemsEqual
We have been able to use them since then, because
testtools required unittest2, which still included it. With testtools
removing Python 2.7 support [3][4], we will lose support for
assertItemsEqual, so we should switch to use assertCountEqual.
[1] - https://bugs.python.org/issue17866
[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd
[3] - testing-cabal/testtools#286
[4] - testing-cabal/testtools#277
Change-Id: Iaa8251a1e9965a00fe99b7a740a104c011260340
assertRaisesRegexp was renamed to assertRaisesRegex in Py3.2
For more details, please check:
https://docs.python.org/3/library/
unittest.html#unittest.TestCase.assertRaisesRegex
Change-Id: I89cce19e80b04074aab9f49a76c7652acace78b3
Closes-Bug: #1436957
Showing the full name in flow __str__() isn't expecially
helpful and clutters up graphviz usage and similar so if a taskflow
built-in pattern is stringified just use the short name (that does
not start with taskflow.patterns instead of the full long name).
Change-Id: Icd8c26eab1e19d6ecf9c4e8e82e6d6902ce5b6ea
This unifies all the patterns to be graph based so
that they are more uniform and there underlying constraints
are more easy to understand (taskflow basically processes
graphs).
Change-Id: Ib2ab07c1c87165cf40a06508128010887f658391
Since graphs are composed of 'nodes' it seems more
appropriate to use that terminology (which is known
to people with graph experience) instead of the non
descriptive and/or standard 'item' terminology.
Change-Id: I04a4521386d3cdf7e58fb9fa8cf26c00443c2cf6
The current implementation seems a little cryptic so updating it
to clearly indicate the atom count.
Change-Id: I4f97e458a4b80e33b3d6348a3ef632398586ed47
In order to make it possible to have a symbol
tree we need to relax the constraints that are
being imposed by the graph flow.
Part of blueprint taskflow-improved-scoping
Change-Id: I2e14de2131c3ba4e3e4eb3108477583d0f02dae2
In order to make it possible to have a symbol
tree we need to relax and remove the constraints
that are being imposed by the unordered constraints
and later move those constraint checks and validations
into the engines compilation stage.
Part of blueprint taskflow-improved-scoping
Change-Id: I80718b4bc01fbf0dce6a95cd2fac7e6e2e1814d1
In order to make it possible to have a symbol
tree we need to relax and remove the constraints
that are being imposed by the linear constraints
and later move those constraint checks and validations
into the engines compilation stage.
Part of blueprint taskflow-improved-scoping
Change-Id: I6efdc821ff991e83572d89f56be5c678d007f9f8
Group the exceptions into the following groups
* Storage
* Jobs
* Execution
* Other (wrapped failure here)
This grouping makes it easier to understand where
one type of exception should be used vs using another
type of exception.
Backwards incompatible changes:
* StorageError -> StorageFailure
* AlreadyExists -> Duplicate
* WrappedFailure now inherits from Exception
and not directly from TaskFlowException since it
wraps arbitrary other exceptions and is not
specific to taskflow.
Cleanups:
* JobNotFound -> NotFound
* EmptyFlow -> Empty
* JobAlreadyExists -> AlreadyExists
* InvariantViolation (X)
* ConnectionFailure (X)
Change-Id: I0e1e81b513fbbc7adb8bfaa1244993e345ab70d3
This commit adds unit tests that check graph flow methods without
executing or flattening it. Now-redundant tests from other test
suites are deleted.
Change-Id: I8dafe0f9b295428831eddb3f9fd48f042d2f1ffc
This change adds unit tests that check unordered flow methods
without loading it into engine and executing it.
Change-Id: I665b6fe070759061edf7a7da4f117c0269c9c3cf
- add 'invariant': True to all links produced by linear flow;
- write new unit tests for basic functionality of linear flow
pattern;
- remove some simple now-redundant unit tests from
test_flow_dependencies.
Change-Id: I1f4fa8a1dfc61485555a10e8d0629a67aab1997f
