The assertItemsEqual method has been removed in Python 3.3 [1] but
it was kept alive by unittest2, imported by testtools. For better
compatibility, change to assertCountEqual.
[1] https://bugs.python.org/issue17866
Change-Id: Iea76915f25eb2e505750d509bdd06758afe324de
(cherry picked from commit b5603cc45c)
The unit test 'tackerclient.tests.unit.osc.v1.test_vnflcm_op_occs.
TestListVnfLcmOp.test_take_action_with_filter' is failing with below
error message,
DEBUG: TypeError: Object of type 'FormatComplexDataColumn' is not
JSON serializable
Background:
In class TestListVnfLcmOp definition, "create_vnflcm_op_occs" function
is called and list of fake vnflcm op occs dictionary is store in
vnflcm_op_occs_obj.
Now this dictionary is used in two unit test cases "test_take_action"
and "test_take_action_with_filter".
In order to evaluate test results, in "test_take_action" test case,
"get_vnflcm_op_occ_data" function is called using "vnflcm_op_occs_obj"
which appends the data in dictionary.
Later this dictionary "vnflcm_op_occs_obj" is again used in
"test_take_action_with_filter".
Implementation:
This patch creates a separate list of fake vnflcm op occs dictionary for
both the test cases.
This issue has been impacting below reviews as well,
[1] https://review.opendev.org/c/openstack/python-tackerclient/+/636893
[2] https://review.opendev.org/c/openstack/python-tackerclient/+/781314
Co-Authored: Yasufumi Ogawa <yasufum.o@gmail.com>
Closes-Bug: #1919350
Change-Id: I0d62f77cf5d1e9ec0b0a7c404abab83f97b708ba
Add ``openstack vnflcm op list`` to python-tackerclient.
This command can execute getting the list of VNF LCM
Operation Occurrences. User can specify filters for more
specific results.
Note:
- Filtering for the following attributes:
operationParams, error, resourceChanges and
changedInfo is only limited to the parent
attribute. Currently, child attributes/nested
attributes are not searchable.
Implements: blueprint support-fundamental-lcm
Spec: https://specs.openstack.org/openstack/tacker-specs/specs/wallaby/support-fundamental-vnf-lcm-based-on-ETSI-NFV.html
Change-Id: Ie0b3399946d2a705011269025102d9380102ca92
In python 3, all strings are considered as unicode string.
This patch drops the explicit unicode literal (u'...')
or (u"..") appearances from the unicode strings.
Note: The scope of the patch is to drop unicode literal prefix
from python source code files, documentation and comment are overlook.
Co-Authored-By: Manpreet Kaur kaurmanpreet2620@gmail.com
Change-Id: I5316037871109838a03ff4561b7b38dcc56bc447
Scale command cannot be executed without '--additional-param-file'
option, because there is a problem with branch process. Modify branch
process when using this parameter.
And, I uniform cardinality mismatches of specification definition [1]
in some arguments are resolved. This change has no impact of the order
of setting.
[1]https://specs.openstack.org/openstack/tacker-specs/specs/victoria/support-scale-api-based-on-etsi-nfv-sol.html
Closes-Bug: #1903280
Change-Id: I1dd2c71760112982abd2b4b7da6dbaafd7077614
This update is to drop all of six support to move
Closes-bug: #1900389
Change-Id: Ia6c61751203e98d432344dc9a52fe65bdb062af0
Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>
Fix some exception messages because some exception messages are not
outputed as expected.
In addition, the codes that seems to improve readability by explicitly
specifying the arguments are also modified.
Change-Id: I425d15ea9f5a3d0b6132ffd03cb577e583239c3a
Closes-Bug: #1881510
Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.
Change-Id: I1bae5d2d97304b81588ce059916326e1117136e3
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Co-Authored-By: Hiroo Kitamura <hiroo.kitamura@ntt-at.co.jp>
If user list vnf packages with --exclude_default option, it should
display all attributes except default set of complex.
$ openstack vnf package list --exclude_default
Expected fields:
'id', 'vnfProductName', 'onboardingState', 'usageState',
'operationalState', '_links', 'vnfdVersion', 'vnfProvider',
'vnfSoftwareVersion', 'vnfdId'
Actual fields displayed are:
'id', 'vnfProductName', 'onboardingState', 'usageState',
'operationalState'
Fixed this issue and now it will display fields as mentioned above in
expected fields.
Closes-Bug: 1875330
Change-Id: I61da40d2e6e7e42999b7ab2d2441cddde64118d9
Display show command data in human_readable format for better
readability for complex attributes of vnf instance like
'vimConnectionInfo', 'instantiatedVnfInfo', '_links'.
Please checkout below link to see the difference in vnflcm show
response data before and after resolving the issue.
http://paste.openstack.org/show/792866
Change-Id: I52684618f7042f5566ea3bed7255d17d2fd61df2
Display show command data in human_readable format for better
readability for complex attributes of vnf package like 'softwareImages',
'checksum', '_links' and 'useDefinedData'.
Please checkout below link to see the difference in vnf package show
response data before and after resolving the issue.
http://paste.openstack.org/show/792305/
Change-Id: I4827437461fd42b4da8a90d7f8ef703625c78cf5
The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.
Fix problems found.
Change-Id: I7a43ff6d91bad919dcaa450e66ef492a1d3a03ef
Added command support for downloading csar vnf package contents.
Change-Id: I6371ebdf0dd9d127ca88bcd721a31036d11ea5fc
Implements: bp enhance-vnf-package-support-part1
Added command support for fetching VNFD of the vnf package.
Please see results here:-
http://paste.openstack.org/show/789212/
Change-Id: Ifa15ddf7ff306ed2705cf7a170d9e9f512491fba
Implements: bp enhance-vnf-package-support-part1
Added command support for updating vnf package.
Please see results here:-
http://paste.openstack.org/show/788463
Change-Id: I0cd32d531db569b7013332fcfaaaefde403e7aed
Implements: bp enhance-vnf-package-support-part1
Added a new command ``openstack vnflcm heal`` to heal vnf
instance.
Blueprint: support-etsi-nfv-specs
Change-Id: I31165e1def0a53a56e1fcefd1877630712bfab5e
Added a new command ``openstack vnflcm list`` to list the vnf instances.
Blueprint: support-etsi-nfv-specs
Change-Id: I4ef7ac0dd4d4744c74ceb13df6b4438a090ac72a
Added a new command ``openstack vnflcm create`` to create a new vnf.
Blueprint: support-etsi-nfv-specs
Change-Id: Ia90955df6ac141661c3d58e4de4e098c4cb51aab
assertItemsEqual was removed from Python's unittest.TestCase in
Python 3.3 [1][2]. We have been able to use them since then, because
testtools required unittest2, which still included it. With testtools
removing Python 2.7 support [3][4], we will lose support for
assertItemsEqual, so we should switch to use assertCountEqual.
[1] - https://bugs.python.org/issue17866
[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd
[3] - testing-cabal/testtools#286
[4] - testing-cabal/testtools#277
Change-Id: I1d77929d26af29e5d060eefdac85a5da2dd145d6
When you pass non-existing vnf package uuid to ``vnf package upload``
command as shown below, it doesn't show user-friendly message as it's
shown in case ``vnf package show`` command.
$openstack vnf package upload --path sample_vnf_pkg.zip dummy-id
"404-tackerFault"
This patch fixes this issue and now it will output below error message:
$openstack vnf package upload --path sample_vnf_pkg.zip dummy-id
Can not find requested vnf package: dummy-id
Change-Id: I84de0140463d6bd834d3bcc22f6a6cea1fef9130
Closes-Bug: #1799683
Added support vnf package upload command and their unit test cases.
Please see result here.
http://paste.openstack.org/show/766299/
Change-Id: I88da4e209413a00d52c73fc83983ed2f5fd273c6
Implements: bp tosca-csar-mgmt-driver
Added support for below three commands and their unit test cases.
1.vnf package list
2.vnf package show
3.vnf package delete
Please see results here
http://paste.openstack.org/show/774848/
Change-Id: I47e3e99a42aa36ab286fa01802999deb964a168f
Implements: bp tosca-csar-mgmt-driver
Added support vnf package create command and their unit test cases.
Please see the results here:
http://paste.openstack.org/show/775422/
Change-Id: Idf59847aaf33e360dae696eae819d217ae63570f
Implements: bp tosca-csar-mgmt-driver
Current tacker client requires us to mention ssl_ca_cert
and set it to None if we don't want to use ssl cert. This
patch along with another patch on the tacker server side
will make ssl_ca_cert a truly optional config. And, only
the correct ssl_ca_cert will be able to authenticate.
Tacker Server changes: https://review.openstack.org/#/c/546580/
Change-Id: Ic87fe3382e100183c685c3b34768a5a5de889982
Currently, Tacker can not communicate with VIM endpoints that
use SSL. This patch will add cert_verify parameter, user can
set "cert_verify" to False (default value is True) to disable
verifying SSL.
Change-Id: I0af2a0f91ecda2a63cf6233d780e1dd7c064513c
