9 Commits

Author SHA1 Message Date
Stephen Finucane
73c66035c4 hacking: Add doctests
Nothing actually tests these yet, but it is the desired behavior.

Change-Id: I3c89234a7a06e06f2740aec0bc7dc19da9cafeb5
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2026-03-25 00:44:28 +01:00
Stephen Finucane
47ac6e2780 hacking: Fix check for missing ignore_missing calls
Change-Id: I54f7bf2026507b357fdf921993c69913e7c32db2
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2026-03-25 00:44:28 +01:00
Stephen Finucane
39842bcf0b hacking: Check for overly complicated client access
Change-Id: I531c0879c413cf500b099826047d03dd90dc0f5d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2026-03-25 00:44:05 +01:00
Stephen Finucane
793739ad01 hacking: Make check for duplicate clients less specific
Change-Id: Ie08a09c209d24d54b062a44e5b535c8a2926285c
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2026-03-25 00:14:07 +01:00
Stephen Finucane
afc32da264 hacking: Fix typos
0 != O.

Change-Id: Iea443da7e802607081150c52d38be2f28293a969
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2026-03-25 00:14:01 +01:00
Stephen Finucane
de81f47305 hacking: Ensure use of openstackclient.command
These have the necessary type hints for the clientmanager and
should always be used.

Change-Id: I8420212be63dbeaff02c97823e1b80441cbc62ca
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2026-03-10 13:20:50 +00:00
Takashi Kajinami
92a277ff4c ruff: Enable E5 check
... to enforce maximum line length, to keep consistent code format.

Note that E501 check is disabled in test code now, until we decide how
to update ~50 lines violating the limit due to too long names.

Change-Id: I122c8b9035d6381dafb34438517c26b01e5201f5
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
2025-12-11 02:43:20 +09:00
Stephen Finucane
db6c34c2c7 hacking: Check for missing ignore_missing calls
This comes up in reviews frequently. Let's automate it.

Change-Id: Ia7ebd7cf29fe4550b22921e898bebaaa5f7bb4f6
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-11-14 11:54:41 +00:00
Stephen Finucane
eb7c4c61a9 Add new hacking rules
To catch some obvious issues.

Change-Id: Ic0ddc95100811e7b313b519aad7d687a1415020b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-11-07 15:45:51 +00:00