openstack/python-openstackclient
Code Issues Proposed changes
Files
9.0.0
python-openstackclient/.pre-commit-config.yaml

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

29 lines
783 B
YAML
Raw Permalink Normal View History

Add pre-commit This is helpful to automate code style checks at runtime. We include documentation on how to run this as well as a general overview of style guidelines in OSC. Change-Id: I2dc5a0f760ce53269ae25677560b2611cc6bfd91 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-03-11 16:20:15 +00:00
---
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
pre-commit: Bump versions We need to rename two hooks. Change-Id: I15582a23da6ea6babf2b277ff443b7cdb764c9f9 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-10-10 10:39:41 +01:00
rev: v6.0.0
Add pre-commit This is helpful to automate code style checks at runtime. We include documentation on how to run this as well as a general overview of style guidelines in OSC. Change-Id: I2dc5a0f760ce53269ae25677560b2611cc6bfd91 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-03-11 16:20:15 +00:00
hooks:
- id: trailing-whitespace
- id: mixed-line-ending
args: ['--fix', 'lf']
exclude: '.*\.(svg)$'
pre-commit: Bump versions We need to rename two hooks. Change-Id: I15582a23da6ea6babf2b277ff443b7cdb764c9f9 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-10-10 10:39:41 +01:00
- id: fix-byte-order-marker
Add pre-commit This is helpful to automate code style checks at runtime. We include documentation on how to run this as well as a general overview of style guidelines in OSC. Change-Id: I2dc5a0f760ce53269ae25677560b2611cc6bfd91 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-03-11 16:20:15 +00:00
- id: check-executables-have-shebangs
- id: check-merge-conflict
- id: debug-statements
- id: check-yaml
files: .*\.(yaml|yml)$
pre-commit: Allow unsafe YAML We're using tags in '.zuul.yaml', which requires use of the unsafe parser [1]. [1] https://stackoverflow.com/a/45967047 Change-Id: Ib97480f6fcaba7406ffe284e1935744346684b8b Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2022-07-04 12:14:56 +01:00
args: ['--unsafe']
pre-commit: Migrate from flake8 to ruff Well, mostly. We still keep our own flake8 hooks and the hacking hooks enabled. Everything else can be handled by ruff. Doing this enables a couple of hacking checks that were previously unaddressed. It also highlights a few cases that flake8 missed. Both are addressed. Change-Id: If81c7055e9ef692425da2789bae18a96d04b104f Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-08-29 10:53:30 +01:00
- repo: https://github.com/astral-sh/ruff-pre-commit
Run mypy from tox This avoids the need to duplicate our dependency list in multiple places and allows us to take advantage of tox's dependency management infrastructure, to ensure we always get the latest and greatest version of a package allowed by upper-constraints. While here, we also update the versions of the remaining pre-commit hooks and change the indentation of the tox file to align with the two indent spacing used for other SDK projects. This makes copy-pasting easier. Change-Id: Ibde8ecda673b2346c82aab68d4f4b49be08414ae Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-12-11 13:33:40 +00:00
rev: v0.15.1
pre-commit: Migrate from flake8 to ruff Well, mostly. We still keep our own flake8 hooks and the hacking hooks enabled. Everything else can be handled by ruff. Doing this enables a couple of hacking checks that were previously unaddressed. It also highlights a few cases that flake8 missed. Both are addressed. Change-Id: If81c7055e9ef692425da2789bae18a96d04b104f Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-08-29 10:53:30 +01:00
hooks:
pre-commit: Bump versions We need to rename two hooks. Change-Id: I15582a23da6ea6babf2b277ff443b7cdb764c9f9 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-10-10 10:39:41 +01:00
- id: ruff-check
pre-commit: Migrate pyupgrade to ruff Change-Id: Ic50d2a5e0bc9dcdfe29f382607135cab510cd396 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-09-12 17:57:14 +01:00
args: ['--fix', '--unsafe-fixes']
pre-commit: Migrate from black to ruff format Change-Id: I28ca7d31d30272002799f3e2832105dc67c60538 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-08-29 10:55:32 +01:00
- id: ruff-format
pre-commit: Bump linter versions We also migrate to the native hacking pre-commit hook. Change-Id: Idb5a825c20cb7f189997a4d6c3a9a88218fdb335 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-01-23 11:47:52 +00:00
- repo: https://opendev.org/openstack/hacking
Run mypy from tox This avoids the need to duplicate our dependency list in multiple places and allows us to take advantage of tox's dependency management infrastructure, to ensure we always get the latest and greatest version of a package allowed by upper-constraints. While here, we also update the versions of the remaining pre-commit hooks and change the indentation of the tox file to align with the two indent spacing used for other SDK projects. This makes copy-pasting easier. Change-Id: Ibde8ecda673b2346c82aab68d4f4b49be08414ae Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2025-12-11 13:33:40 +00:00
rev: 8.0.0
Add pre-commit This is helpful to automate code style checks at runtime. We include documentation on how to run this as well as a general overview of style guidelines in OSC. Change-Id: I2dc5a0f760ce53269ae25677560b2611cc6bfd91 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
2021-03-11 16:20:15 +00:00
hooks:
pre-commit: Bump linter versions We also migrate to the native hacking pre-commit hook. Change-Id: Idb5a825c20cb7f189997a4d6c3a9a88218fdb335 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-01-23 11:47:52 +00:00
- id: hacking
additional_dependencies: []
pre-commit: Bump versions We also drop the default language setting: everything is Python 3 nowadays. Change-Id: I9dc9573a86c93416d1bbbc782dac76ecdda6effd Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-08-29 10:57:20 +01:00
exclude: '^(doc|releasenotes)/.*$'
Copy Permalink