From 486376e91b1f9a7680371036e470b8692804e917 Mon Sep 17 00:00:00 2001 From: Sean McGinnis Date: Tue, 5 Sep 2017 19:56:06 -0500 Subject: [PATCH] Change CINDER_LVM_TYPE to 'auto' as the default This was previously set to thin as the default, but at the time there were failures seen with what appeared to be race conditions when creating snapshots. These failures are not seen locally, and we have a lot of installs using the default auto by this point with no reports from the field of seeing this failure. This is to be able to more extensively test this in the gate, and hopefully get this switched over to be able to thinly provision by default when possible. Change-Id: I3e99adadd1c37ba8b24b6cb71a8969ffc93f75a1 Related-bug: #1642111 --- lib/cinder | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/cinder b/lib/cinder index 03328f31b6..9a2be653d1 100644 --- a/lib/cinder +++ b/lib/cinder @@ -70,12 +70,11 @@ CINDER_SERVICE_PROTOCOL=${CINDER_SERVICE_PROTOCOL:-$SERVICE_PROTOCOL} CINDER_SERVICE_LISTEN_ADDRESS=${CINDER_SERVICE_LISTEN_ADDRESS:-$SERVICE_LISTEN_ADDRESS} # What type of LVM device should Cinder use for LVM backend -# Defaults to default, which is thick, the other valid choice -# is thin, which as the name implies utilizes lvm thin provisioning. -# Thinly provisioned LVM volumes may be more efficient when using the Cinder -# image cache, but there are also known race failures with volume snapshots -# and thinly provisioned LVM volumes, see bug 1642111 for details. -CINDER_LVM_TYPE=${CINDER_LVM_TYPE:-default} +# Defaults to auto, which will do thin provisioning if it's a fresh +# volume group, otherwise it will do thick. The other valid choices are +# default, which is thick, or thin, which as the name implies utilizes lvm +# thin provisioning. +CINDER_LVM_TYPE=${CINDER_LVM_TYPE:-auto} # Default backends # The backend format is type:name where type is one of the supported backend