Add support for multiple db:s in cluster mode #89

New issue

Open

opened 2025-05-05 13:27:52 +02:00 by mickenordin · 2 comments

mickenordin commented

2025-05-05 13:27:52 +02:00

Owner

Valkey has merged a pr with this functionality, and I think it would be useful for us as well:

https://github.com/valkey-io/valkey/pull/1671

The patch did not apply cleanly after about one minute of testing it, so some amount of adapting is needed.

Valkey has merged a pr with this functionality, and I think it would be useful for us as well: https://github.com/valkey-io/valkey/pull/1671 The patch did not apply cleanly after about one minute of testing it, so some amount of adapting is needed.

ddevault commented

2025-05-07 03:47:05 +02:00

Owner

I'm also interested to see what other valkey improvements are worth including. Any bugfixes are an obvious one to have, new features are probably more debatable -- since we're in the position of chasing stability rather than innovation.

I am curious about this indeed, it would be pretty nice to have. Applying it will be some work but probably not too difficult. I know that Valkey has done some changes upstream which are a bit more disruptive and will start making merging in their patches more difficult if we don't follow along (e.g. they refactored how client flags are stored), but for the time being I think it's manageable if not annoying. I'm also interested to see what other valkey improvements are worth including. Any bugfixes are an obvious one to have, new features are probably more debatable -- since we're in the position of chasing stability rather than innovation.

ddevault commented

2025-05-07 03:47:53 +02:00

Owner

We will need to figure out if there are any prerequisites that were merged into valkey earlier that we didn't pull, though, but I think we can be reasonably confident that if the tests pass it's good to go.